fix(doctor): match the pinned Claude registration id contract and accept versionless Cursor manifests - #243
Merged
Merged
Conversation
…ept versionless Cursor manifests
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🦋 Changeset detectedLatest commit: 566f90d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This was referenced Sep 2, 2026
Generated plugin contract matrix: catch source→artifact→dev→installed-host drift before release
#218
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #236 addressing the two Codex review findings, both verified against pinned evidence:
containsPluginNamerecursively searched theplugin list --jsonoutput for any object with a matchingname, which could false-positive on unrelated objects and missed the actual contract. Doctor now follows the pinned registration contract fromtests/support/packed-native-smoke.ts: the output is a top-level array and a direct-loaded bundle is registered exactly when some entry hasid === '<name>@inline'. A non-array shape is an honest AB7312 failure; a parsed array without the id stays AB7311unregistered. Regression tests cover the name-only false positive and the wrapped-object shape.src/adapters/schemas/cursor/plugin.schema.json) requires onlyname;versionis optional.readInstalledManifestnow accepts a versionless manifest (a present-but-non-stringversionstill invalidates the candidate), and the bundle version-collision branch only fires when the installed copy actually records a version — a versionless destination with differing content isdrifted, notconflicted. Regression tests cover versionless-installed, non-string-version-corrupt, and drifted-not-conflicted.Patch changeset included.
Test plan
pnpm lint— 0 errors, 0 warningspnpm typecheck